[
https://issues.apache.org/jira/browse/HDDS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589397#comment-16589397
]
Xiaoyu Yao commented on HDDS-356:
---------------------------------
Thanks [~anu] for the update. The patch v2 looks excellent to me. Just few more
comments:
*RDBStore.java*
Line 68: NIT: this is not needed as RocksDB has statically loaded the native
library upon class load.
Line 107: NIT: we can use toIOException() here.
Line 142: NIT: local variable handles can be folded in the for loop.
*RDBTable.java*
Line 138: this iterate() method seems very similar to standard
Iterator#forEachRemaining?
Can we move it to overwrite forEachRemaining in RDBStoreIterator?
> Support ColumnFamily based RockDBStore and TableStore
> -----------------------------------------------------
>
> Key: HDDS-356
> URL: https://issues.apache.org/jira/browse/HDDS-356
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-356.001.patch, HDDS-356.002.patch
>
>
> This is to minimize the performance impacts of the expensive RocksDB table
> scan problems from background services disabled by HDDS-355.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
