[
https://issues.apache.org/jira/browse/HDFS-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588294#comment-16588294
]
Yiqun Lin commented on HDFS-13831:
----------------------------------
The patch almost looks good to me, [~jianliang.wu]. Some minors comments:
* Rename {{block.deletion.increment}} to
{{dfs.namenode.block.deletion.increment}}
* Rename to {{BLOCK_DELETION_INCREMENT}} to
{{DFS_NAMENODE_BLOCK_DELETION_INCREMENT}}.
* The description of the setting can update to following
{noformat}
The number of block deletion increment.
This setting will control the block increment deletion rate to ensure that
other waiters on the lock can get in.
{noformat}
> Make block increment deletion number configurable
> -------------------------------------------------
>
> Key: HDFS-13831
> URL: https://issues.apache.org/jira/browse/HDFS-13831
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.1.0
> Reporter: Yiqun Lin
> Assignee: Ryan Wu
> Priority: Major
> Attachments: HDFS-13831.001.patch, HDFS-13831.002.patch
>
>
> When NN deletes a large directory, it will hold the write lock long time. For
> improving this, we remove the blocks in a batch way. So that other waiters
> have a chance to get the lock. But right now, the batch number is a
> hard-coded value.
> {code}
> static int BLOCK_DELETION_INCREMENT = 1000;
> {code}
> We can make this value configurable, so that we can control the frequency of
> other waiters to get the lock chance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
