[ 
https://issues.apache.org/jira/browse/HDFS-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590024#comment-16590024
 ] 

Ryan Wu commented on HDFS-13831:
--------------------------------

Thx [~linyiqun]. I have updated the patch and  add the error-checking logic to 
ensure block-increment-deletion 

a positive integer. Moreover, we don't need to add the new test since the 
_TestLargeDirectoryDelete_  already  __  covers the scenario_. S_o, I just set 
the block-increment-deletion  via configuration in _TestLargeDirectoryDelete._

> Make block increment deletion number configurable
> -------------------------------------------------
>
>                 Key: HDFS-13831
>                 URL: https://issues.apache.org/jira/browse/HDFS-13831
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Yiqun Lin
>            Assignee: Ryan Wu
>            Priority: Major
>         Attachments: HDFS-13831.001.patch, HDFS-13831.002.patch, 
> HDFS-13831.003.patch
>
>
> When NN deletes a large directory, it will hold the write lock long time. For 
> improving this, we remove the blocks in a batch way. So that other waiters 
> have a chance to get the lock. But right now, the batch number is a 
> hard-coded value.
> {code}
>   static int BLOCK_DELETION_INCREMENT = 1000;
> {code}
> We can make this value configurable, so that we can control the frequency of 
> other waiters to get the lock chance. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to