[ 
https://issues.apache.org/jira/browse/HDFS-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590451#comment-16590451
 ] 

Íñigo Goiri commented on HDFS-13858:
------------------------------------

Maybe we should be a little more specific in the error messages.
In one case we should say that we have too many parameters and that the maximum 
is X.
In the other case, we should say that X is not a valid option and that the 
valid ones are Y,Z.

> RBF: dfsrouteradmin safemode command is accepting any valid/invalid second 
> argument. Add check to have single valid argument to safemode command
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13858
>                 URL: https://issues.apache.org/jira/browse/HDFS-13858
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: federation
>            Reporter: Soumyapn
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: RBF
>         Attachments: HDFS-13858-01.patch
>
>
> *Scenario:*
> Current behaviour for the dfsrouteradmin command is: First argument should be 
> valid one. What ever value we give as the second argument, the command is 
> successfull.
>  
> *Examples:*
> hdfs dfsrouteradmin -safemode enter leave
> hdfs dfsrouteradmin -safemode leave enter
> hdfs dfsrouteradmin -safemode get jashfuesfhsk
> hdfs dfsrouteradmin -safemode leave leave
>  
> With the above examples, command is successfull for the first argument.
>  
> *Expected:*
> Add check to have single valid argument to the safemode command
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to