[
https://issues.apache.org/jira/browse/HDFS-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591073#comment-16591073
]
Ayush Saxena commented on HDFS-13858:
-------------------------------------
Thanx [~elgoiri] for the suggestions.
yes indeed the exceptions were quite general.
Have made the changes as suggested by you.Just one thing not added what are the
valid parameters in case of invalid parameters since after error
message,printUsage() method is called which will print the correct usage.
Hence we will be repeating the stuff again.
Uploaded the patch v3 with the suggestions.
Pls Review!!!!
> RBF: dfsrouteradmin safemode command is accepting any valid/invalid second
> argument. Add check to have single valid argument to safemode command
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13858
> URL: https://issues.apache.org/jira/browse/HDFS-13858
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: federation
> Reporter: Soumyapn
> Assignee: Ayush Saxena
> Priority: Major
> Labels: RBF
> Attachments: HDFS-13858-01.patch, HDFS-13858-02.patch,
> HDFS-13858-03.patch
>
>
> *Scenario:*
> Current behaviour for the dfsrouteradmin command is: First argument should be
> valid one. What ever value we give as the second argument, the command is
> successfull.
>
> *Examples:*
> hdfs dfsrouteradmin -safemode enter leave
> hdfs dfsrouteradmin -safemode leave enter
> hdfs dfsrouteradmin -safemode get jashfuesfhsk
> hdfs dfsrouteradmin -safemode leave leave
>
> With the above examples, command is successfull for the first argument.
>
> *Expected:*
> Add check to have single valid argument to the safemode command
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
