[
https://issues.apache.org/jira/browse/HDDS-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591859#comment-16591859
]
Xiaoyu Yao commented on HDDS-359:
---------------------------------
Thanks [~anu] for working on this. The patch looks good to me overall. Just a
few minor comments:
DBConfigFromFile.java
Line 122: can we move this to line 117 so that the caller does not need to
check null. I see there are logic later in DBStoreBuild.java relies on null
check. This can be addressed later with the comments for Line 148-170 in
DBStoreBuilder.java.
DBStoreBuilder.java
Line 79: NIT: annotate for test only?
Line 118: NIT: rename from processTableNames => processTables?
Line 141: this assumes all tables have the same column family option. Is it
possible to have per table column family option (either fully customized or
predefined set of column family options)
{color:#000000}Line 144: should we document in the build class that addTable()
should not add "{color}{color:#658aba}default" column family explicitly?{color}
Line 148-170: the current code loads from rocksDBOption parameter, OR config
file OR pre-defined db profiles? Is it possible to allow all of these and
merge/overwrite with the config file like hadoop configs. (This can be added
later with a separate JIRA)
TableConfig.java
Can we abstract the table config otherwise we can use ColumnFamilyOptions
directly?
Test.db.ini
Add an exception to the license check plugin?
TestDBConfigFromFile.java
Line 67: should we clean up the copied test ini file in the tearDown?
> RocksDB Profiles support
> ------------------------
>
> Key: HDDS-359
> URL: https://issues.apache.org/jira/browse/HDDS-359
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-359.001.patch, HDDS-359.002.patch,
> HDDS-359.003.patch
>
>
> This allows us to tune the OM/SCM DB for different machine configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
