[
https://issues.apache.org/jira/browse/HDDS-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592222#comment-16592222
]
Anu Engineer commented on HDDS-359:
-----------------------------------
{quote}I think the confusion is that DBStoreBuilder#addTable() allows add per
table column family option. But the caller processTableNames() only pass the
same one from dbProfile.getColumnFamilyOptions() in line 141 based on SSD/DISK.
{quote}
I see the issue you are mentioning and I can see the source of confusion this
creating. When we call the function addTable(string, option), internally we are
adding that to a set.
{{private Set<TableConfig> tables;}}
However, when the user makes a call to addTable(string) where the user does not
specify an Option, we add that a list of Strings.
{{private List<String> tableNames;}}
Later in the "processTables" call, we walk the tableNames and make calls into
addTable(string, default Option). The addTable with name only makes some code
simpler, especially if you are happy with the defaults.
bq. I mean the TableConfig class is almost the same as ColumnFamilyOption. We
could potentially use it directly.
Yes, that would mean that we have to send into 2 lists, one forthe name and
another for ColumnFamilyOption. This is class creates a relationship between
those 2 variables.
> RocksDB Profiles support
> ------------------------
>
> Key: HDDS-359
> URL: https://issues.apache.org/jira/browse/HDDS-359
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-359.001.patch, HDDS-359.002.patch,
> HDDS-359.003.patch, HDDS-359.004.patch
>
>
> This allows us to tune the OM/SCM DB for different machine configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
