[
https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593936#comment-16593936
]
Chao Sun commented on HDFS-13791:
---------------------------------
Thanks [~xkrogen]! I think the approach looks good to me. Some minor comments:
1. can we align the {{LimitedFrequencyLogHelper}} across different places? esp.
the {{preLogAction}} and {{postLogAction}} in {{FSEditLogLoader}}.
2. {{LoggingAction#addValues}} only accept {{long}} which doesn't seem general
enough, as well as {{LogAction#[getMin,getMax]}}. Maybe we should have a more
specific interface inherits the {{LogAction}} for the min, max metrics?
> Limit logging frequency of edit tail related statements
> -------------------------------------------------------
>
> Key: HDFS-13791
> URL: https://issues.apache.org/jira/browse/HDFS-13791
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs, qjm
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13791-HDFS-12943.000.patch
>
>
> There are a number of log statements that occur every time new edits are
> tailed by a Standby NameNode. When edits are tailing only on the order of
> every tens of seconds, this is fine. With the work in HDFS-13150, however,
> edits may be tailed every few milliseconds, which can flood the logs with
> tailing-related statements. We should throttle it to limit it to printing at
> most, say, once per 5 seconds.
> We can implement logic similar to that used in HDFS-10713. This may be
> slightly more tricky since the log statements are distributed across a few
> classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
