[
https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595716#comment-16595716
]
Chen Liang commented on HDFS-13779:
-----------------------------------
Thanks for the patch [~xkrogen]! LGTM overall, only some minor comments:
# {{ObserverReadProxyProvider#invoke}}, change {{observerCount}} to some like
{{failedObserverCount}} ?
# {{ObserverReadProxyProvider#changeProxy}}, seems we can reduce the scope of
locking to after the {{if (currentProxy != initial)}} check, so that it does
not need to grab the lock just for this check and then return. May not be that
necessary, I'm okay with either way.
# {{CachingHAProxyFactory}}, move the initialization of {{cache}} into
constructor?
# More of a question, do we really need to have {{CachingHAProxyFactory}}?
because for now it seems to me that even without caching,
{{createProxyIfNeeded}} is doing the job that only when proxy is null it will
create proxy. Am I missing something here?
> Implement performFailover logic for ObserverReadProxyProvider.
> --------------------------------------------------------------
>
> Key: HDFS-13779
> URL: https://issues.apache.org/jira/browse/HDFS-13779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Konstantin Shvachko
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13779-HDFS-12943.000.patch,
> HDFS-13779-HDFS-12943.WIP00.patch
>
>
> Currently {{ObserverReadProxyProvider}} inherits {{performFailover()}} method
> from {{ConfiguredFailoverProxyProvider}}, which simply increments the index
> and switches over to another NameNode. The logic for ORPP should be smart
> enough to choose another observer, otherwise it can switch to a SBN, where
> reads are disallowed, or to an ANN, which defeats the purpose of reads from
> standby.
> This was discussed in HDFS-12976.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
