[ 
https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598955#comment-16598955
 ] 

Erik Krogen commented on HDFS-13779:
------------------------------------

Good catches, Konstantin! I should have taken a closer look after my v001 -> 
v002 revisions. I also removed the {{throws IOException}} clause from the 
{{ObserverReadProxyProvider}} constructors, as it is no longer applicable. 
Attaching v003 patch, which I also just committed to HDFS-12943 branch. Thanks 
for the help [~shv] and [~vagarychen]!

> Implement performFailover logic for ObserverReadProxyProvider.
> --------------------------------------------------------------
>
>                 Key: HDFS-13779
>                 URL: https://issues.apache.org/jira/browse/HDFS-13779
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Konstantin Shvachko
>            Assignee: Erik Krogen
>            Priority: Major
>             Fix For: HDFS-12943
>
>         Attachments: HDFS-13779-HDFS-12943.000.patch, 
> HDFS-13779-HDFS-12943.001.patch, HDFS-13779-HDFS-12943.002.patch, 
> HDFS-13779-HDFS-12943.003.patch, HDFS-13779-HDFS-12943.WIP00.patch
>
>
> Currently {{ObserverReadProxyProvider}} inherits {{performFailover()}} method 
> from {{ConfiguredFailoverProxyProvider}}, which simply increments the index 
> and switches over to another NameNode. The logic for ORPP should be smart 
> enough to choose another observer, otherwise it can switch to a SBN, where 
> reads are disallowed, or to an ANN, which defeats the purpose of reads from 
> standby.
> This was discussed in HDFS-12976.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to