[
https://issues.apache.org/jira/browse/HDDS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602256#comment-16602256
]
Lokesh Jain commented on HDDS-358:
----------------------------------
[~anu] Can you please rebase the patch?
The patch looks good to me. Please find my comments below.
# KeyDeletingService - We can have the logs in KeyDeletingTask and can convert
them to debug instead. We can have the log for the case when block deletion
result from SCM is a failure. We can also have the log for the number of keys
which are being deleted by the service.
# We also need to start the KeyDeletingService and the block deletion tests.
We can do it as part of separate Jira though.
# OmMetadataManagerImpl:50 - Star import
> Use DBStore and TableStore for DeleteKeyService
> -----------------------------------------------
>
> Key: HDDS-358
> URL: https://issues.apache.org/jira/browse/HDDS-358
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-358.001.patch
>
>
> DeleteKeysService and OpenKeyDeleteService.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
