[
https://issues.apache.org/jira/browse/HDDS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604365#comment-16604365
]
Nanda kumar commented on HDDS-358:
----------------------------------
Thanks [~anu] for the patch. +1, Looks good to me. I will commit this shortly.
Few NITs which I will fix while committing:
KeyDeletingService:
class javadoc has to be modified.
{{getRunCount}} and {{getDeletedKeyCount}} can be annotated with
@VisibleForTesting
OmKeyArgs:
{{addLocationInfo}} can be annotated with @VisibleForTesting
> Use DBStore and TableStore for DeleteKeyService
> -----------------------------------------------
>
> Key: HDDS-358
> URL: https://issues.apache.org/jira/browse/HDDS-358
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-358.001.patch, HDDS-358.002.patch,
> HDDS-358.003.patch
>
>
> DeleteKeysService and OpenKeyDeleteService.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
