[
https://issues.apache.org/jira/browse/HDDS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602694#comment-16602694
]
Nanda kumar commented on HDDS-297:
----------------------------------
Thanks [~msingh] for updating the patch. Overall the patch looks excellent to
me.
Some very minor comments.
*ozone-default.xml*
>> ALL is used as the default replication level
But the default value in xml is {{MAJORITY}}
Even in {{ScmConfigKeys#DFS_CONTAINER_RATIS_REPLICATION_LEVEL_DEFAULT}} the
default value is {{ReplicationLevel.MAJORITY}}
*XceiverServerRatis.java*
L:371 & 375 String concatenation can be replaced with StringBuilder append call.
*XceiverClientRatis.java*
Why do we need the old raftGroup for re-initialization?
*MiniOzoneClusterImpl.java*
In {{getHddsDatanodeIndex}}, if we return {{-1}}, when we are not able to find
the datanode as part of the MiniOzoneCluster we will end up in
{{ArrayIndexOutOfBoundsException}}. This should never happen, in case if it
happens it will be easy for us to debug if we throw RuntimeException when we
are not able to find the datanode as part of mini cluster.
> Add pipeline actions in Ozone
> -----------------------------
>
> Key: HDDS-297
> URL: https://issues.apache.org/jira/browse/HDDS-297
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-297.001.patch, HDDS-297.002.patch,
> HDDS-297.003.patch, HDDS-297.004.patch, HDDS-297.005.patch,
> HDDS-297.006.patch, HDDS-297.007.patch, HDDS-297.008.patch, HDDS-297.009.patch
>
>
> Pipeline in Ozone are created out of a group of nodes depending upon the
> replication factor and type. These pipeline provide a transport protocol for
> data transfer.
> Inorder to detect any failure of pipeline, SCM should receive pipeline
> reports from Datanodes and process it to identify various raft rings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
