[
https://issues.apache.org/jira/browse/HDDS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605240#comment-16605240
]
Ajay Kumar edited comment on HDDS-351 at 9/6/18 4:19 AM:
---------------------------------------------------------
[~anu] thanks for review.
{quote}MiniOzoneClusterImpl.java#shutdown - Looks like we delete a bunch of
directotries and then call stop(). Shouldn't stop be done before delete
operation?{quote}
Patch merely refactors the existing logic. Didn't changed the sequence earlier
to avoid any potential failure in other test classes but changed it in patch
v8.
{quote}TestSCMChillModeManager.java# private static double chillModeCutoff; –
unused variable.{quote}
removed.
{quote}TestUtils.java
Line length – CheckStyle will fail.{quote}
Fixing this makes it more ugly and unreadable but its done in latest patch.
{quote}Is there a reason why we don't use imports? and use smaller names in
code ?
org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo{quote}
You might have missed but TestUtils already imports class with same name from
different pakcage
(org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerInfo)
Since java doesn't have support of import alias, other class is used with fully
qualified path.
was (Author: ajayydv):
[~anu] thanks for review.
{quote}MiniOzoneClusterImpl.java#shutdown - Looks like we delete a bunch of
directotries and then call stop(). Shouldn't stop be done before delete
operation?{quote}
Patch merely refactors the existing logic. Didn't changed the sequence earlier
to avoid any potential failure in other test classes but changed it in patch
v8.
{quote}TestSCMChillModeManager.java# private static double chillModeCutoff; –
unused variable.{quote}
removed.
{quote}TestUtils.java
Line length – CheckStyle will fail.{quote}
Fixing this makes it more ugly and unreadable but its done in latest patch.
{quote}Is there a reason why we don't use imports? and use smaller names in
code ?
org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo{quote}
You might have missed but same class already imports same class from different
pakcage
(org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerInfo)
Since java doesn't have support of import alias, other class is used with fully
qualified pathname.
> Add chill mode state to SCM
> ---------------------------
>
> Key: HDDS-351
> URL: https://issues.apache.org/jira/browse/HDDS-351
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-351.00.patch, HDDS-351.01.patch, HDDS-351.02.patch,
> HDDS-351.03.patch, HDDS-351.04.patch, HDDS-351.05.patch, HDDS-351.06.patch,
> HDDS-351.07.patch, HDDS-351.08.patch
>
>
> Add chill mode state to SCM
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
