[ 
https://issues.apache.org/jira/browse/HDDS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606688#comment-16606688
 ] 

Ajay Kumar edited comment on HDDS-351 at 9/7/18 4:02 AM:
---------------------------------------------------------

[~anu] SCMChillModeManager constructor has a preconditions check for null 
container list. Latest patch removes it and handles it in 
ContainerChillModeRule. For second point regarding race condition i think it is 
already handled with if condition in last patch. 
{code}
if (containerMap.containsKey(c.getContainerID())) {
          if(containerMap.remove(c.getContainerID()) != null) {
            containerWithMinReplicas.getAndAdd(1);
          }
  }
{code}


was (Author: ajayydv):
[~anu] SCMChillModeManager constructor has a preconditions check for null 
container list. Latest patch removes it and handles it in 
ContainerChillModeRule. For second point regarding race condition i think it is 
handled with new if condition. 
{code}
if (containerMap.containsKey(c.getContainerID())) {
          if(containerMap.remove(c.getContainerID()) != null) {
            containerWithMinReplicas.getAndAdd(1);
          }
  }
{code}

> Add chill mode state to SCM
> ---------------------------
>
>                 Key: HDDS-351
>                 URL: https://issues.apache.org/jira/browse/HDDS-351
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-351.00.patch, HDDS-351.01.patch, HDDS-351.02.patch, 
> HDDS-351.03.patch, HDDS-351.04.patch, HDDS-351.05.patch, HDDS-351.06.patch, 
> HDDS-351.07.patch, HDDS-351.08.patch, HDDS-351.09.patch, HDDS-351.10.patch, 
> HDDS-351.11.patch, HDDS-351.12.patch, HDDS-351.13.patch
>
>
> Add chill mode state to SCM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to