[ https://issues.apache.org/jira/browse/HDDS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608306#comment-16608306 ]
Anu Engineer commented on HDDS-399: ----------------------------------- [~msingh] , [~shashikant] Thanks for the patch. I have some minor feedback of the patch. # closePipeline -- we have added pipeline.delete(). However, closePipeline seems to be invoked for both close and Timeout. Not sure deleting the entry from the Pipeline DB for timeout is the right choice. # It would be nice if we could use a formal state machine like we have used in ContainerStateManager etc. Instead of having the state of a pipeline sprinkled all over the code with cases and functions. We have functions like addExistingPipeline(), processNodeReport(), finalizePipeline(), updatePipelineState -- where we are modifying the state of the pipeline. However, there is no one place where the state machine is defined. > Handle pipeline discovery on SCM restart. > ----------------------------------------- > > Key: HDDS-399 > URL: https://issues.apache.org/jira/browse/HDDS-399 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: SCM > Affects Versions: 0.2.1 > Reporter: Mukul Kumar Singh > Assignee: Mukul Kumar Singh > Priority: Blocker > Fix For: 0.2.1 > > Attachments: HDDS-399.001.patch, HDDS-399.002.patch > > > On SCM restart, as part on node registration, SCM should find out the list on > open pipeline on the node. Once all the nodes of the pipeline have reported > back, they should be added as active pipelines for further allocations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org