[ 
https://issues.apache.org/jira/browse/HDDS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616866#comment-16616866
 ] 

Mukul Kumar Singh commented on HDDS-399:
----------------------------------------

Thanks for reviewing the patch [~nandakumar131].
I have addressed all the comments in the v6 patch.

{code}
Why do we need to create new SCM instance during restart?
{code}
One of the reason for this was to make sure that we recreate new pipeline 
objects as part of restart in {{PipelineSelector#reloadExistingPipelines}}. 
Since these objects are created as part of Constrcutors I wanted to re-create 
new SCM object to make sure that unit tests are not working on stale objects in 
the cache.

> Handle pipeline discovery on SCM restart.
> -----------------------------------------
>
>                 Key: HDDS-399
>                 URL: https://issues.apache.org/jira/browse/HDDS-399
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>    Affects Versions: 0.2.1
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: HDDS-399.001.patch, HDDS-399.002.patch, 
> HDDS-399.003.patch, HDDS-399.004.patch, HDDS-399.005.patch, HDDS-399.006.patch
>
>
> On SCM restart, as part on node registration, SCM should find out the list on 
> open pipeline on the node. Once all the nodes of the pipeline have reported 
> back, they should be added as active pipelines for further allocations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to