[ 
https://issues.apache.org/jira/browse/HDFS-13776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614772#comment-16614772
 ] 

Dibyendu Karmakar commented on HDFS-13776:
------------------------------------------

Thanks, [~elgoiri] for reviewing the patch.

I have tackled all the comments in the new patch [^HDFS-13776-004.patch].

For the UT regarding StoragePolicySatisfier, currently, TestRouterRpc is 
creating a cluster with 2 nameservices and 12 datanodes. If we want to include 
this satisfier unit test in TestRouterRpc it will be a little messy.

If we are good with the running time of the new test class then I think we 
should go with that. Otherwise, I'll try to include it in the existing 
TestRouterRpc.

> RBF: Add Storage policies related ClientProtocol APIs
> -----------------------------------------------------
>
>                 Key: HDFS-13776
>                 URL: https://issues.apache.org/jira/browse/HDFS-13776
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Dibyendu Karmakar
>            Assignee: Dibyendu Karmakar
>            Priority: Major
>         Attachments: HDFS-13776-000.patch, HDFS-13776-001.patch, 
> HDFS-13776-002.patch, HDFS-13776-003.patch, HDFS-13776-004.patch
>
>
> Currently unsetStoragePolicy and getStoragePolicy are not implemented in 
> RouterRpcServer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to