[
https://issues.apache.org/jira/browse/HDDS-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620726#comment-16620726
]
Hadoop QA commented on HDDS-447:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 14m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 54s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
1s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
17s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hadoop-ozone in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
19s{color} | {color:red} dist in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
16s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 16s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
16s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 5 new + 1 unchanged - 3 fixed = 6
total (was 4) {color} |
| {color:orange}-0{color} | {color:orange} shelldocs {color} | {color:orange}
0m 15s{color} | {color:orange} The patch generated 12 new + 106 unchanged - 10
fixed = 118 total (was 116) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
27s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 0m
41s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
17s{color} | {color:red} root in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 16s{color}
| {color:red} root in the patch failed. {color} |
| {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue} 0m
16s{color} | {color:blue} ASF License check generated no output? {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 84m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HDDS-447 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12940427/HDDS-447.003.patch |
| Optional Tests | asflicense shellcheck shelldocs compile javac javadoc
mvninstall mvnsite unit shadedclient xml |
| uname | Linux 9751037552fc 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c0956ee |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| shellcheck | v0.4.6 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-mvninstall-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-compile-root.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-compile-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-mvnsite-root.txt
|
| shellcheck |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/diff-patch-shellcheck.txt
|
| shelldocs |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/diff-patch-shelldocs.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-javadoc-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/testReport/ |
| Max. process+thread count | 407 (vs. ulimit of 10000) |
| modules | C: . hadoop-dist hadoop-hdds hadoop-hdds/client hadoop-hdds/common
hadoop-hdds/container-service hadoop-hdds/framework hadoop-hdds/server-scm
hadoop-hdds/tools hadoop-ozone hadoop-ozone/client hadoop-ozone/common
hadoop-ozone/datanode hadoop-ozone/dist hadoop-ozone/docs
hadoop-ozone/integration-test hadoop-ozone/objectstore-service
hadoop-ozone/ozone-manager hadoop-ozone/ozonefs hadoop-ozone/tools
hadoop-project U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/1156/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> separate ozone-dist and hadoop-dist projects with real classpath separation
> ---------------------------------------------------------------------------
>
> Key: HDDS-447
> URL: https://issues.apache.org/jira/browse/HDDS-447
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDDS-447-ozone-0.2.001.patch, HDDS-447.003.patch
>
>
> Currently we have the same hadoop-dist project to create both the ozone and
> and the hadoop distribution.
> To decouple ozone and hadoop build it would be great to create two different
> dist project.
> The hadoop-dist should be cloned to hadoop-ozone/dist and from
> hadoop-dist/pom.xml we can remove the hdds/ozone related items and from
> hadoop-ozone/dist/pom.xml we can remove the core hadoop related part.
> An other issue with the current distribution schema is the lack of real
> classpath separation.
> The current hadoop distribution model is defined in the hadoop-project-dist
> which is parent of all the component projects and the output of the
> distribution generation will be copied by the dist-layout-stitching. There is
> no easy way to use command specific classpath as the classpath is defined in
> component level (hdfs/yarn/mapreduce).
> With this approach we will have a lot of unnecessary dependencies on the
> classpath (which were not on the classpath at the time of the unit tests) and
> it's not possible (as an example) use different type of jaxrs stack for
> different services (s3gateway vs scm).
> As a simplified but more effective approach I propose to use the following
> method:
> 1. don't use hadoop-project-dist for ozone projects any more
> 2. During the build generate a classpath descriptor (with the
> dependency:build-classpath maven plugin/goal) for all the projects
> 3. During the distribution copy all the required dependencies (with
> dependency:copy maven plugin/goal) to a lib folder (share/ozone/lib)
> 4. During the distribution copy all the classpath descriptors to the
> classpath folder (share/ozone/classpath)
> 5. Put only the required jar files to the classpath with reading the
> classpath descriptor
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
