[
https://issues.apache.org/jira/browse/HDDS-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622379#comment-16622379
]
Ajay Kumar commented on HDDS-448:
---------------------------------
[~GeLiXin] thanks for rebasing the patch. Patch LGTM. Few comments:
NodeStateMap
* L53/L270/L300/L316/: Replace "stat with stats"
* L270 Same as above
* getNodeStat: Do we need the read lock, since it is concurrentHashMap?
* getNodeStats: Shall we return a unmodifiable copy of map?
* setNodeStat/removeNodeStat: Do we need lock here?
NodeStateManager
* L415/L450 Replace "stat with stats"
* L425 Lets propagate back the NodeNotFoundException.
* L432 Rephrase " a map contains all node stats." to "nodeStateMap" or "map
with node stats"?
*
SCMNodeManager
L313: Shall we move put operation to L298?
> Move NodeStat to NodeStatemanager from SCMNodeManager.
> ------------------------------------------------------
>
> Key: HDDS-448
> URL: https://issues.apache.org/jira/browse/HDDS-448
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDDS-448.000.patch, HDDS-448.001.patch
>
>
> This issue try to make the SCMNodeManager clear and clean, as the stat
> information should be kept by NodeStatemanager (NodeStateMap). It's also
> described by [~nandakumar131] as something \{{TODO}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
