[
https://issues.apache.org/jira/browse/HDDS-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628958#comment-16628958
]
Ajay Kumar commented on HDDS-448:
---------------------------------
[~GeLiXin] thanks for updating the patch. As per javadoc of
SCMNodeManager#getNodeStat it should return null if node is dead or doesn't
exist. Shall we return null from catch clause and update the javadoc return
statement as well? As stats for dead node will return a valid NodeStat object
but with 0 values.
{code} @return node stat if it is live/stale, null if it is dead or does't
exist.{code}
to
{code} @return node stat if it is live/stale, null if it is decommissioned or
does't exist.{code}
> Move NodeStat to NodeStatemanager from SCMNodeManager.
> ------------------------------------------------------
>
> Key: HDDS-448
> URL: https://issues.apache.org/jira/browse/HDDS-448
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDDS-448.000.patch, HDDS-448.001.patch,
> HDDS-448.002.patch, HDDS-448.003.patch, HDDS-448.004.patch
>
>
> This issue try to make the SCMNodeManager clear and clean, as the stat
> information should be kept by NodeStatemanager (NodeStateMap). It's also
> described by [~nandakumar131] as something \{{TODO}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
