[
https://issues.apache.org/jira/browse/HDDS-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626218#comment-16626218
]
Ajay Kumar commented on HDDS-401:
---------------------------------
[~GeLiXin] thanks for updating the patch. LGTM. One minor nit and +1 after it.
SCMNodeManager#processDeadNode: Remove put op at L507 as that stat is already
in map or replace it with putIfAbsent?
There seems to be another innocuous bug in DeadNodeHandler. We can discuss it
in separate jira.
{code}org.apache.hadoop.hdds.scm.exceptions.SCMException: No entry exist for
containerId: id=1 in replica map.
at
org.apache.hadoop.hdds.scm.container.states.ContainerStateMap.removeContainerReplica(ContainerStateMap.java:268)
at
org.apache.hadoop.hdds.scm.container.ContainerStateManager.removeContainerReplica(ContainerStateManager.java:536)
at
org.apache.hadoop.hdds.scm.node.DeadNodeHandler.onMessage(DeadNodeHandler.java:75)
at
org.apache.hadoop.hdds.scm.node.DeadNodeHandler.onMessage(DeadNodeHandler.java:39)
at
org.apache.hadoop.hdds.server.events.SingleThreadExecutor.lambda$onMessage$1(SingleThreadExecutor.java:85)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745){code}
Call to removeContainerReplica from DeadNodeHandler.onMessage should be wrapped
in
> Update storage statistics on dead node
> ---------------------------------------
>
> Key: HDDS-401
> URL: https://issues.apache.org/jira/browse/HDDS-401
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDDS-401.000.patch, HDDS-401.001.patch,
> HDDS-401.002.patch, HDDS-401.003.patch, HDDS-401.004.patch
>
>
> This is a follow-up Jira for HDDS-369.
> As per [~ajayydv]'s
> [comment|https://issues.apache.org/jira/browse/HDDS-369?focusedCommentId=16594120&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16594120],
> on detecting a dead node in the cluster, we should update the storage stats
> such as usage, space left.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
