[
https://issues.apache.org/jira/browse/HDDS-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626883#comment-16626883
]
LiXin Ge commented on HDDS-401:
-------------------------------
Thanks [~ajayydv] for your comments.
{quote}SCMNodeManager#processDeadNode: Remove put op at L507 as that stat is
already in map or replace it with putIfAbsent?
{quote}
I have removed the redundant put operation at L507 in patch 005.
{quote}Call to removeContainerReplica from DeadNodeHandler.onMessage should be
wrapped in try catch.
{quote}
I'm pleasure to create a trace Jira and work on it, but I'm sorry that I didn't
fully understand what you mean, call to {{removeContainerReplica}} from
{{DeadNodeHandler.onMessage}} was in try catch already, we can see the log of
stack just because {{DeadNodeHandler.onMessage}} catch and print the exception
message threw by {{removeContainerReplica}}.
> Update storage statistics on dead node
> ---------------------------------------
>
> Key: HDDS-401
> URL: https://issues.apache.org/jira/browse/HDDS-401
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDDS-401.000.patch, HDDS-401.001.patch,
> HDDS-401.002.patch, HDDS-401.003.patch, HDDS-401.004.patch, HDDS-401.005.patch
>
>
> This is a follow-up Jira for HDDS-369.
> As per [~ajayydv]'s
> [comment|https://issues.apache.org/jira/browse/HDDS-369?focusedCommentId=16594120&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16594120],
> on detecting a dead node in the cluster, we should update the storage stats
> such as usage, space left.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
