[ 
https://issues.apache.org/jira/browse/HDFS-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634613#comment-16634613
 ] 

BELUGA BEHR commented on HDFS-13947:
------------------------------------

[~elgoiri] !

My personal view is that with wide-screen monitors being the normal, 80 
characters is too draconian.  I would leave it as such.

However, unit tests are related.  I've got to address that; I know what's 
causing it, just need to figure out a workaround.  Thanks!

> Review of DirectoryScanner Class
> --------------------------------
>
>                 Key: HDFS-13947
>                 URL: https://issues.apache.org/jira/browse/HDFS-13947
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: HDFS-13947.1.patch, HDFS-13947.2.patch
>
>
> Review of Directory Scanner.   Replaced a lot of code with Guava MultiMap.  
> Some general house cleaning and improved logging.  For performance, using 
> {{ArrayList}} instead of {{LinkedList}} where possible, especially since 
> these lists can be quite large a LinkedList will consume a lot of memory and 
> be slow to sort/iterate over.
> https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist-in-java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to