[
https://issues.apache.org/jira/browse/HDFS-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634777#comment-16634777
]
Kitti Nanasi commented on HDFS-13947:
-------------------------------------
Thanks [~belugabehr] for the patch and [~elgoiri] for the review.
I have some comments:
- I know it is an existing and minor thing, but
DirectoryScanner#Stats#toString does not have spaces after the ":" sign.
- In DirectoryScanner#getDiskReport why is a null added to compilersInProgress
in case of provided storage type if the null will be ignored later on?
- I think it would be clearer to change the default for
DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT in another jira,
so this one can contain only the refactoring work.
> Review of DirectoryScanner Class
> --------------------------------
>
> Key: HDFS-13947
> URL: https://issues.apache.org/jira/browse/HDFS-13947
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Major
> Attachments: HDFS-13947.1.patch, HDFS-13947.2.patch
>
>
> Review of Directory Scanner. Replaced a lot of code with Guava MultiMap.
> Some general house cleaning and improved logging. For performance, using
> {{ArrayList}} instead of {{LinkedList}} where possible, especially since
> these lists can be quite large a LinkedList will consume a lot of memory and
> be slow to sort/iterate over.
> https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist-in-java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
