[ 
https://issues.apache.org/jira/browse/HDDS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642592#comment-16642592
 ] 

Bharat Viswanadham commented on HDDS-523:
-----------------------------------------

Hi [~elek]

Thanks for the patch.

Code changes for DeleteObject LGTM.

*I have a few minor comments on robot tests.*

1. ${BUCKET} is set in Create volume and bucket for the tests. This will be 
called only if

OZONE_TEST to true. I think we need to make ${BUCKET} also variable to make 
this work both on s3gateway and ozone cluster. Otherwise ${BUCKET} will not be 
set when OZONE_TESTS is set to false.

 

2. Should not contain ${result} 500 in awscli.robot tests, why do we need this 
change?

 

> Implement DeleteObject REST endpoint
> ------------------------------------
>
>                 Key: HDDS-523
>                 URL: https://issues.apache.org/jira/browse/HDDS-523
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: newbie
>         Attachments: HDDS-523.001.patch
>
>
> Simple delete Object call.
> Implemented by HDDS-444 without the acceptance tests.
> https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectDELETE.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to