[ 
https://issues.apache.org/jira/browse/HDDS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644929#comment-16644929
 ] 

Elek, Marton commented on HDDS-523:
-----------------------------------

Thank you to check it [~anu]

0. First of all I would suggest to test it with 'aws s3api delete-object' 
instead of 'aws s3 rm'. The later one uses HEAD calls which is not yet fully 
implemented. (I removed the s3 based tests as suggested by [~bharatviswa])

3. This is not a problem. It seems that you use different bucket names (bucket1 
vs bucket2)

2. This is a real problem. I updated the code. Thanks to find it.

+1: I removed the aws s3 based robot tests (they are failing anyway), and added 
additional 'aws s3api' based tests based on your use cases (non-existent 
buckets/keys, prefix, ...). All the tests are passed with both real amazon 
endpoint and with our gateway endpoint.
{code:java}
robot -v bucket:ozonetest -v ENDPOINT_URL:https://s3.us-east-2.amazonaws.com -v 
OZONE_TEST:false  s3/awscli.robot                         
==============================================================================
Awscli :: S3 gateway test with aws cli                                        
==============================================================================
File upload and directory list                                        | PASS |
------------------------------------------------------------------------------
Delete file with s3api                                                | PASS |
------------------------------------------------------------------------------
Delete file with s3api, file doesn't exist                            | PASS |
------------------------------------------------------------------------------
Delete dir with s3api                                                 | PASS |
------------------------------------------------------------------------------
Delete file with s3api, file doesn't exist, prefix of a real file     | PASS |
------------------------------------------------------------------------------
Delete file with s3api, bucket doesn't exist                          | PASS |
------------------------------------------------------------------------------
Awscli :: S3 gateway test with aws cli                                | PASS |
6 critical tests, 6 passed, 0 failed
6 tests total, 6 passed, 0 failed
==============================================================================
Output:  
/home/elek/projects/hadoop/hadoop-ozone/dist/src/main/smoketest/output.xml
Log:     
/home/elek/projects/hadoop/hadoop-ozone/dist/src/main/smoketest/log.html
Report:  
/home/elek/projects/hadoop/hadoop-ozone/dist/src/main/smoketest/report.html
{code}
 
{code:java}
docker-compose exec datanode bash                                 
hadoop@b9f7d06982b1:~$ robot smoketest/s3/awscli.robot
==============================================================================
Awscli :: S3 gateway test with aws cli                                        
==============================================================================
File upload and directory list                                        | PASS |
------------------------------------------------------------------------------
Delete file with s3api                                                | PASS |
------------------------------------------------------------------------------
Delete file with s3api, file doesn't exist                            | PASS |
------------------------------------------------------------------------------
Delete dir with s3api                                                 | PASS |
------------------------------------------------------------------------------
Delete file with s3api, file doesn't exist, prefix of a real file     | PASS |
------------------------------------------------------------------------------
Delete file with s3api, bucket doesn't exist                          | PASS |
------------------------------------------------------------------------------
Awscli :: S3 gateway test with aws cli                                | PASS |
6 critical tests, 6 passed, 0 failed
6 tests total, 6 passed, 0 failed
==============================================================================
Output:  /opt/hadoop/output.xml
Log:     /opt/hadoop/log.html
Report:  /opt/hadoop/report.html{code}

> Implement DeleteObject REST endpoint
> ------------------------------------
>
>                 Key: HDDS-523
>                 URL: https://issues.apache.org/jira/browse/HDDS-523
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: newbie
>         Attachments: HDDS-523.001.patch, HDDS-523.002.patch, 
> HDDS-523.003.patch
>
>
> Simple delete Object call.
> Implemented by HDDS-444 without the acceptance tests.
> https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectDELETE.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to