[
https://issues.apache.org/jira/browse/HDFS-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644328#comment-16644328
]
BELUGA BEHR commented on HDFS-13981:
------------------------------------
Working on unit test {{TestRouterAllResolver}}. The test is a bit wonky. I'm
trying to see if I can approve it. In the test, each subcluster has the same
exact amount of available space. Previously, the implementation was such that
if there was a tie, a subcluster would be picked randomly, so the test passed.
In my implementation, the first subcluster in the list of all subclusters is
picked because they're all the same and it keeps with the design of "picking
the node with the most available space." Well, when they're all the same, the
first node is as good as any other. Except for the very initial install of the
HDFS service, it is soooo unlikely that any two subclusters have the same exact
amount of data (down to the byte) that the test hardly makes sense. I'm trying
to re-work the test to include some sizes.
> Review of AvailableSpaceResolver.java
> -------------------------------------
>
> Key: HDFS-13981
> URL: https://issues.apache.org/jira/browse/HDFS-13981
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-13981.1.patch
>
>
> * No behavior changes, just optimizing and paring down the code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
