[ 
https://issues.apache.org/jira/browse/HDFS-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644617#comment-16644617
 ] 

Yiqun Lin commented on HDFS-13981:
----------------------------------

[~belugabehr], actually for the unit test of AvailableSpaceResolver, I used a 
mock way to make the test ( can look into TestAvailableSpaceResolver). But I'm 
fine if you want to make this improve under TestRouterAllResolver. In the test 
cases under TestRouterAllResolver, it looks like a more real way and has the 
data being written there.
 I will  take some time to review the updated patch, :).
  

> Review of AvailableSpaceResolver.java
> -------------------------------------
>
>                 Key: HDFS-13981
>                 URL: https://issues.apache.org/jira/browse/HDFS-13981
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-13981.1.patch
>
>
> * No behavior changes, just optimizing and paring down the code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to