[
https://issues.apache.org/jira/browse/HDDS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646404#comment-16646404
]
Elek, Marton commented on HDDS-522:
-----------------------------------
Thanks [~bharatviswa] the patch.
Some comments:
# I would remove all the LOG.info lines.
# I would add unit tests at least for the header parsing. (I think this is the
reason behind the many LOG statement. I think it's even too much lines for
debug log)
# I think the authorization headers could be parsed in a separated filters
similar to the request ids. But it could be implemented later. This is more
like a prototype.
# I tried to test it with aws client, but don't know how can I found the
created volume. Do you have any hints (in the robot tests it's not checked if
the volume is really created only the response should be there)?
# I would improve the robot tests (long-term)
## I would make it possible to execute the tests one-by-one. It requires to
move the initialization from test cases to keywords (see HDDS-523)
## I would like to execute all the s3 unit tests with using real aws s3
endpoint. Don't know how is it possible with the bucket.robot (again, in
HDDS-523, it works for the old tests)
> Implement PutBucket REST endpoint
> ---------------------------------
>
> Key: HDDS-522
> URL: https://issues.apache.org/jira/browse/HDDS-522
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: newbie
> Attachments: HDDS-522.00.patch, HDDS-522.01.patch, HDDS-522.02.patch
>
>
> The create bucket creates a bucket using createS3Bucket which has been added
> as part of HDDS-577.
> [https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUT.html]
> Stub implementation is created as part of HDDS-444. Need to finalize, check
> the missing headers, add acceptance tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
