[ 
https://issues.apache.org/jira/browse/HDDS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647093#comment-16647093
 ] 

Bharat Viswanadham commented on HDDS-522:
-----------------------------------------

Hi [~elek]

Thanks for the review.
 # Done
 # Done
 # Agreed, when security comes all API requests might require this. I will open 
a new Jira for this.
 # Added in robot test to check volume. Volume name right now is s3+acces key id
 # Updated the robot tests to make it work with both our s3 gateway and amazon 
end point. And also some regions of AWS only support version 4 and some supoort 
version 2. 

Output *of robot tests With Aws end point:*

 

 
{code:java}
HW13865:smoketest bviswanadham$ robot -v 
ENDPOINT_URL:https://s3.us-east-1.amazonaws.com -v OZONE_TEST:false -v 
BUCKET:bh-9098 s3/bucketv2.robot
==============================================================================
Bucketv2 :: S3 gateway test with aws cli for bucket operations                
==============================================================================
Setup s3 Tests                                                        | PASS |
------------------------------------------------------------------------------
Create Bucket                                                         | PASS |
------------------------------------------------------------------------------
Bucketv2 :: S3 gateway test with aws cli for bucket operations        | PASS |
2 critical tests, 2 passed, 0 failed
2 tests total, 2 passed, 0 failed
 
HW13865:smoketest bviswanadham$ robot -v 
ENDPOINT_URL:https://s3.us-east-1.amazonaws.com -v OZONE_TEST:false -v 
BUCKET:bh-9098 s3/bucketv4.robot
==============================================================================
Bucketv4 :: S3 gateway test with aws cli for bucket operations                
==============================================================================
Setup s3 Tests                                                        | PASS |
------------------------------------------------------------------------------
Create Bucket                                                         | PASS |
------------------------------------------------------------------------------
Bucketv4 :: S3 gateway test with aws cli for bucket operations        | PASS |
2 critical tests, 2 passed, 0 failed
2 tests total, 2 passed, 0 failed
==============================================================================
==============================================================================
{code}
 

 
{code:java}
Output of robot tests with S3Gateway:
HW13865:smoketest bviswanadham$ ./test.sh --env ozones3 s3
Executing test s3 with 
/Users/bviswanadham/workspace/open-hadoop/hadoop/hadoop-ozone/dist/target/ozone-0.4.0-SNAPSHOT/smoketest/../compose/ozones3/docker-compose.yaml
Removing network ozones3_default
WARNING: Network ozones3_default not found.
Creating network "ozones3_default" with the default driver
Creating ozones3_ozoneManager_1 ... 
Creating ozones3_datanode_1 ... 
Creating ozones3_scm_1 ... 
Creating ozones3_s3g_1 ... 
Creating ozones3_datanode_1
Creating ozones3_s3g_1
Creating ozones3_ozoneManager_1
Creating ozones3_s3g_1 ... done
Waiting 30s for cluster start up...
Waiting 30s for cluster start up...
==============================================================================
S3                                                                            
==============================================================================
S3.Awscli :: S3 gateway test with aws cli                                     
==============================================================================
Create volume and bucket for the tests                                | PASS |
------------------------------------------------------------------------------
Install aws s3 cli                                                    | PASS |
------------------------------------------------------------------------------
File upload and directory list                                        | PASS |
------------------------------------------------------------------------------
S3.Awscli :: S3 gateway test with aws cli                             | PASS |
3 critical tests, 3 passed, 0 failed
3 tests total, 3 passed, 0 failed
==============================================================================
S3.Bucketv2 :: S3 gateway test with aws cli for bucket operations             
==============================================================================
Setup s3 Tests                                                        | PASS |
------------------------------------------------------------------------------
Create Bucket                                                         | PASS |
------------------------------------------------------------------------------
S3.Bucketv2 :: S3 gateway test with aws cli for bucket operations     | PASS |
2 critical tests, 2 passed, 0 failed
2 tests total, 2 passed, 0 failed
==============================================================================
S3.Bucketv4 :: S3 gateway test with aws cli for bucket operations             
==============================================================================
Setup s3 Tests                                                        | PASS |
------------------------------------------------------------------------------
Create Bucket                                                         | PASS |
------------------------------------------------------------------------------
S3.Bucketv4 :: S3 gateway test with aws cli for bucket operations     | PASS |
2 critical tests, 2 passed, 0 failed
2 tests total, 2 passed, 0 failed
==============================================================================
S3                                                                    | PASS |
7 critical tests, 7 passed, 0 failed
7 tests total, 7 passed, 0 failed
==============================================================================
{code}
 

> Implement PutBucket REST endpoint
> ---------------------------------
>
>                 Key: HDDS-522
>                 URL: https://issues.apache.org/jira/browse/HDDS-522
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Elek, Marton
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: newbie
>         Attachments: HDDS-522.00.patch, HDDS-522.01.patch, HDDS-522.02.patch, 
> HDDS-522.03.patch
>
>
> The create bucket creates a bucket using createS3Bucket which has been added 
> as part of HDDS-577.
> [https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUT.html]
> Stub implementation is created as part of HDDS-444. Need to finalize, check 
> the missing headers, add acceptance tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to