[
https://issues.apache.org/jira/browse/HDDS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659219#comment-16659219
]
Anu Engineer commented on HDDS-694:
-----------------------------------
1. ContainerOperationClient:Line 145:
{code}
+ " leader:" + client.getPipeline().getLeader()
+ " machines:" + client.getPipeline().getMachines());
{code}
is replaced with datanode, is that intentional?
{code}
+ " datanode:" + client.getPipeline().getNodes().get(0)
+ " machines:" + client.getPipeline().getNodes());
{code}
2. Check if Line 211 is correct?
3. Nit: In lot of places we have replaced {{pipeline.getLeader()}} with
{{(pipeline.getNodes().get(0)}}. I am wondering if the earlier form of is more
friendlier for code reading?
[~ljain] Thanks for taking time and explaining this patch to me offline.
> Plugin new Pipeline management code in SCM
> ------------------------------------------
>
> Key: HDDS-694
> URL: https://issues.apache.org/jira/browse/HDDS-694
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-694.001.patch
>
>
> This Jira aims to plugin new pipeline management code in SCM. It removes the
> old pipeline related classes as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
