[ 
https://issues.apache.org/jira/browse/HDDS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663442#comment-16663442
 ] 

Nanda kumar commented on HDDS-694:
----------------------------------

[~ljain], the patch is not applying anymore. Can you rebase it on top of the 
latest changes?

Also can you please fix the checkstyle issues. A couple of very minor comments,

Pipeline.java
 Line:107 We can avoid creation of new ArrayList object by not calling 
{{getNodes}}.
 {{getNodes().get(0)}} can be replaced with 
{{nodeStatus.keySet().iterator().next()}}

RatisPipelineProvider.java
 Line:129 The state should be {{OPEN}}

> Plugin new Pipeline management code in SCM
> ------------------------------------------
>
>                 Key: HDDS-694
>                 URL: https://issues.apache.org/jira/browse/HDDS-694
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: HDDS-694.001.patch, HDDS-694.002.patch
>
>
> This Jira aims to plugin new pipeline management code in SCM. It removes the 
> old pipeline related classes as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to