[
https://issues.apache.org/jira/browse/HDDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661114#comment-16661114
]
Nanda kumar commented on HDDS-692:
----------------------------------
[~horzsolt2006], thanks for working on this.
It is not a good idea to give the actual task to {{ProgressBar}} thread.
The way it should be is
* Instantiate the ProgressBar class with {{PrintStream}}, {{MaxValue}} of type
Long and {{Supplier<Long>}} function.
* ProgressBar#start; this should start the ProgressBar thread
* ProgressBar#shutdown; this should stop the ProgressBar thread
Apart from {{shutdown}} method which waits for the progress bar to complete, we
should also have {{terminate}} method which can be used in case of exception in
the actual job. Upon calling {{terminate}} method, {{ProgressBar}} thread
should immediately terminate.
> Use the ProgressBar class in the RandomKeyGenerator freon test
> --------------------------------------------------------------
>
> Key: HDDS-692
> URL: https://issues.apache.org/jira/browse/HDDS-692
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Zsolt Horvath
> Priority: Major
> Attachments: HDDS-692.001.patch
>
>
> HDDS-443 provides a reusable progress bar to make it easier to add more freon
> tests, but the existing RandomKeyGenerator test
> (hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java)
> still doesn't use it.
> It would be good to switch to use the new progress bar there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
