[
https://issues.apache.org/jira/browse/HDDS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662071#comment-16662071
]
Elek, Marton commented on HDDS-516:
-----------------------------------
Thanks the rebase [~bharatviswa].
LGTM, +1
1. tested with aws s3api copy-object: worked well
2. executed the robot tests: all are passed
3. executed the new robot test with aws endpoint: worked well
I found few, very minor nits:
1. geteTag/seteTag should be getETag/setETag accodring to the java naming
convention
2. sourceInputStream and destOutputStream are closed twice (once at L267/L268,
once in the finally branch.)
3. copyObject is added to the EndpointBase. Will it be used by any other
endpoint or just the ObjectEndpoint? If only by the ObjectEndpoint I would keep
it in the ObjectEndpoint (or in a utility class).
4. OZONE_TEST is not required as a robot Varialble any more.
But none of them are blocking (I can fix 1. during the commit), it's working
very well and well tested.
> Implement CopyObject REST endpoint
> ----------------------------------
>
> Key: HDDS-516
> URL: https://issues.apache.org/jira/browse/HDDS-516
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: S3
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: newbie
> Attachments: HDDS-516.01.patch, HDDS-516.03.patch, HDDS-516.04.patch,
> HDDS-516.05.patch
>
>
> The Copy object is a simple call to Ozone Manager. This API can only be done
> after the PUT OBJECT Call.
> This implementation of the PUT operation creates a copy of an object that is
> already stored in Amazon S3. A PUT copy operation is the same as performing a
> GET and then a PUT. Adding the request header, x-amz-copy-source, makes the
> PUT operation copy the source object into the destination bucket.
> If the Put Object call has this header, then Put Object call will issue a
> rename.
> Work Items or JIRAs
> Detect the presence of the extra header - x-amz-copy-source
> Make sure that destination bucket exists.
> The AWS reference is here:
> https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectCOPY.html
> (This jira is marked as newbie as it requires only basic Ozone knowledge. If
> somebody would be interested, I can be more specific, explain what we need or
> help).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
