[
https://issues.apache.org/jira/browse/HDDS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645127#comment-16645127
]
Elek, Marton commented on HDDS-516:
-----------------------------------
Thanks [~bharatviswa] to working on this. The doesn't apply any more, but I
tested it on top of the original parent (I applied it to 907ef6c2858)
# The biggest problem IMHO is the source and destination are swapped. The
x-amz-copy-source header defines the _source_. But in the code it is used as
the destination.
# I tried to execute the robot tests and didn't work (I think because the
swap: the source file didn't exist)
# You can use
Response.status(Response.Status.{color:#660e7a}OK{color}).entity(result). You
don't need the toXml() method as the JAXB/JAXRS take care about it.
# It's very minor, but this comment (L:120) is misleading: _"{color:#808080}//
Get destination Key Details and find length"{color}_
# Very-very minor: You can remove copyHeader.length() (this is a suggestion by
my IDE, I am not such smart...)
# As I wrote, it requires a minor rebase (As I wrote I tested it with an
earlier HEAD)
> Implement CopyObject REST endpoint
> ----------------------------------
>
> Key: HDDS-516
> URL: https://issues.apache.org/jira/browse/HDDS-516
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: newbie
> Attachments: HDDS-516.01.patch
>
>
> The Copy object is a simple call to Ozone Manager. This API can only be done
> after the PUT OBJECT Call.
> This implementation of the PUT operation creates a copy of an object that is
> already stored in Amazon S3. A PUT copy operation is the same as performing a
> GET and then a PUT. Adding the request header, x-amz-copy-source, makes the
> PUT operation copy the source object into the destination bucket.
> If the Put Object call has this header, then Put Object call will issue a
> rename.
> Work Items or JIRAs
> Detect the presence of the extra header - x-amz-copy-source
> Make sure that destination bucket exists.
> The AWS reference is here:
> https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectCOPY.html
> (This jira is marked as newbie as it requires only basic Ozone knowledge. If
> somebody would be interested, I can be more specific, explain what we need or
> help).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
