[
https://issues.apache.org/jira/browse/HDFS-14028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664058#comment-16664058
]
Adam Antal commented on HDFS-14028:
-----------------------------------
As a second thought I think maybe it's better to just throw an exception if the
folder already exists, ensuring that the user does not accidentally delete the
folder. IMO its a legitimate assumption that the folder does not exist yet.
Also added a test case to be consistent what I just said.
Pending jenkins v1.
> HDFS OIV temporary dir deletes folder
> -------------------------------------
>
> Key: HDFS-14028
> URL: https://issues.apache.org/jira/browse/HDFS-14028
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
>
> The Hadoop Offline Image Viewer tool has an undocumented 'feature' where it
> will silently delete the directory passed in with the -t flag. This blew away
> some important files when someone used a sensible, but ultimately poor choice
> for this directory as the deletion isn't documented.
> For example, if someone were, as root do: 'hdfs oiv -i
> fsimage_00000000000307052343 -p Delimited -t / -o image', bad things would
> happen. This behavior should be documented and probably have a dialog or
> throwing exception.
> There is a piece of code from PBImageTextWriter where a check can be added:
> {code:java}
> LevelDBMetadataMap(String baseDir) throws IOException {
> File dbDir = new File(baseDir);
> if (dbDir.exists()) {
> FileUtils.deleteDirectory(dbDir);
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
