[
https://issues.apache.org/jira/browse/HDFS-14028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664202#comment-16664202
]
Adam Antal commented on HDFS-14028:
-----------------------------------
Thanks [~anu] for the valuable comment.
I agree that it could cause backwards compatibility in such cases. Then I
suggest to add an extra log (WARN) when deleting the existing folder and also
update the docs emphasizing that deletion can occur. I believe it's not
necessarily a bug that the OIV works this way, the problem is rather it did not
get documented. In this way the user gets the information and compatibility
with previous behaviour is also kept so I'm fine with both the original and
this proposed solution.
> HDFS OIV temporary dir deletes folder
> -------------------------------------
>
> Key: HDFS-14028
> URL: https://issues.apache.org/jira/browse/HDFS-14028
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: HDFS-14028.001.patch
>
>
> The Hadoop Offline Image Viewer tool has an undocumented 'feature' where it
> will silently delete the directory passed in with the -t flag. This blew away
> some important files when someone used a sensible, but ultimately poor choice
> for this directory as the deletion isn't documented.
> For example, if someone were, as root do: 'hdfs oiv -i
> fsimage_00000000000307052343 -p Delimited -t / -o image', bad things would
> happen. This behavior should be documented and probably have a dialog or
> throwing exception.
> There is a piece of code from PBImageTextWriter where a check can be added:
> {code:java}
> LevelDBMetadataMap(String baseDir) throws IOException {
> File dbDir = new File(baseDir);
> if (dbDir.exists()) {
> FileUtils.deleteDirectory(dbDir);
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
