[
https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675991#comment-16675991
]
Konstantin Shvachko commented on HDFS-14035:
--------------------------------------------
Liked the patch - it clearly simplifies things. One larger issue, and a few
minor ones.
# In {{AbstractNNFailoverProxyProvider.NNProxyInfo}} you probably don't need
{{serviceProxy}} any more. You should be able to use {{ProxyInfo.proxy}}, which
is already a {{ClientProtocol}}. Don't know exactly how you access it, may be
this logic should go back to {{ObserverReadProxyProvider}} where we know {{<T
extends ClientProtocol>}}.
# Unused import of HAServiceProtocol in NameNodeRpcServer,
AbstractNNFailoverProxyProvider
Also in TestObserverReadProxyProvider
Unused import in ObserverReadProxyProvider
# {{NameNodeProxiesClient}} a few unused imports and constants. It should now
look very similar to trunk version except AlignmentContext changes.
# In {{ClientProtocol.checkAccess()}} should be made coordinated already.
# Check for blank lines like in ClientNamenodeProtocolServerSideTranslatorPB.
> NN status discovery does not leverage delegation token
> ------------------------------------------------------
>
> Key: HDFS-14035
> URL: https://issues.apache.org/jira/browse/HDFS-14035
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-14035-HDFS-12943.001.patch,
> HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch,
> HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch,
> HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch
>
>
> Currently ObserverReadProxyProvider uses
> {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However
> {{HAServiceProtocol}} does not leverage delegation token. So when running an
> application on YARN and when YARN node manager makes this call
> getServiceStatus, token authentication will fail, causing the application to
> fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
