[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677409#comment-16677409 ]
Chao Sun commented on HDFS-14035: --------------------------------- Thanks [~vagarychen]. A couple of comments on patch v8: 1. {{RouterRpcClient#getHAServiceState}} and {{RouterRpcService#getHAServiceState}} seems like an infinite mutual recursion loop. We may also need to add a test for it if it does something non-trivial. 2. Still a couple of unused imports in {{NameNodeProxiesClient}} 3. In {{ClientProtocolAnswer}}, can we use {{HAServiceState}} instead of {{Object}} - it is more precise. > NN status discovery does not leverage delegation token > ------------------------------------------------------ > > Key: HDFS-14035 > URL: https://issues.apache.org/jira/browse/HDFS-14035 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Major > Attachments: HDFS-14035-HDFS-12943.001.patch, > HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch, > HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch, > HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch, > HDFS-14035-HDFS-12943.008.patch, HDFS-14035-HDFS-12943.009.patch > > > Currently ObserverReadProxyProvider uses > {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However > {{HAServiceProtocol}} does not leverage delegation token. So when running an > application on YARN and when YARN node manager makes this call > getServiceStatus, token authentication will fail, causing the application to > fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org