[
https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678386#comment-16678386
]
Kitti Nanasi commented on HDFS-14050:
-------------------------------------
Thanks [~hgadre] for working on this!
It looks good, I only have a minor comment. In the following lines, the last
"{}" is not necessary, because the throwable in the parameter will not replace
it.
{code:java}
LOG.info("Could not obtain block from any node: {}", ie);
LOG.info("Failed to connect to {} : {}", targetAddr, ex);
{code}
> Use parameterized logging construct in NamenodeFsck class
> ---------------------------------------------------------
>
> Key: HDFS-14050
> URL: https://issues.apache.org/jira/browse/HDFS-14050
> Project: Hadoop HDFS
> Issue Type: Task
> Affects Versions: 3.0.0
> Reporter: Hrishikesh Gadre
> Assignee: Hrishikesh Gadre
> Priority: Trivial
> Attachments: HDFS-14050-001.patch, HDFS-14050-002.patch
>
>
> HDFS-13695 implemented a change to use slf4j logger (instead of commons
> logging). But the NamenodeFsck class is still not using parameterized logging
> construct. This came up during the code review for HADOOP-11391. We should
> change logging statements in NamenodeFsck to use slf4j style parameterized
> logging apis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
