[
https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680550#comment-16680550
]
Hrishikesh Gadre commented on HDFS-14050:
-----------------------------------------
[~xiaochen] thanks for the review.
{quote}In NamenodeFsck there's 1 miss:
{code:java}
LOG.error("Fsck: could not copy block " + lblock.getBlock() +
" to " + target, e);{code}
{quote}
This is intentional. slf4j does not allow parameter substitution and printing
stack track as part of the same API (i.e. either you can print a stack trace
with a string message or you can print a parameterized string.
{quote} - I think the LOG.info can move from TestFsck to DFSTestUtil{quote}
Ok. done!
{quote} - The comments in TestFsck about the {{FSPermissionChecker.LOG}} also
seems redundant. Appreciate the explanation for code review, but doesn't feel
like we'd need it to be a code comment. :){quote}
Ok I will remove it. I had added the comment for code readability.
> Use parameterized logging construct in NamenodeFsck class
> ---------------------------------------------------------
>
> Key: HDFS-14050
> URL: https://issues.apache.org/jira/browse/HDFS-14050
> Project: Hadoop HDFS
> Issue Type: Task
> Affects Versions: 3.0.0
> Reporter: Hrishikesh Gadre
> Assignee: Hrishikesh Gadre
> Priority: Trivial
> Attachments: HDFS-14050-001.patch, HDFS-14050-002.patch,
> HDFS-14050-003.patch
>
>
> HDFS-13695 implemented a change to use slf4j logger (instead of commons
> logging). But the NamenodeFsck class is still not using parameterized logging
> construct. This came up during the code review for HADOOP-11391. We should
> change logging statements in NamenodeFsck to use slf4j style parameterized
> logging apis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
