[
https://issues.apache.org/jira/browse/HDDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680708#comment-16680708
]
Bharat Viswanadham commented on HDDS-816:
-----------------------------------------
Hi [~linyiqun]
Thanks for the review.
# Incremented only in commitKey because until we perform the commit Key, it
will not be in ozone. So, that is the reason for doing in commit Key. (As if we
do in Open key, and if the key is not committed, the key will not be visible.
That is the reason for doing this. But i think with doing in commitKey I see an
issue, for same key if version is changed also we increment the num of keys
which we should not do.
# Refactoring is done to make easy for unit testing. I think it is okay to be
in ozonemanager createS3Bucket also, as after creating volume, we create
bucket.
#
{quote}I still not understand why we increase the count for volume creates. If
IOException threw, two cases: 1. volume already created. 2. volume create
failed. Any case of this, we all no need to increase count of volumes. It
should keep the same count.{quote}Actually here I am not incrementing the count
of volumes, I am only incrementing volumeCreates and volumeCreateFails. The
reason for doing this, if we got an exception that means we try to create a
volume for that s3bucket for the first time and it failed. As when it already
exists, we don't throw an exception. So here considering this as volume create
request and incremented volumecreate and volumecreatefails.
> Create OM metrics for bucket, volume, keys
> ------------------------------------------
>
> Key: HDDS-816
> URL: https://issues.apache.org/jira/browse/HDDS-816
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-816.00.patch
>
>
> This Jira is used to create the following metrics in Ozone manager.
> # number of volumes
> # number of buckets
> # number of keys
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
