[
https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683575#comment-16683575
]
Zsolt Venczel commented on HDFS-13998:
--------------------------------------
Thank you [~brahmareddy] for taking a look!
Please find my comments below:
{quote}IMHO, HDFS-13732 change might not require..? As admin will be aware of
configured policy and these are admin commands.
{quote}
For supportability reasons helping out administrators (there could be many) by
displaying the actual outcome of their actions can be valuable.
We support them by providing a warning message as well when the directory is
not empty. I think this is also valuable despite its load (a listStatus command
is executed that adds an extra audit log entry and might also return 1000
FileStatus information by default if the directory is large enough).
{quote}Adding RPC can mislead
For concurrent calls and any error while getting the policy after setting.
{quote}
In this scenario not knowing the default might be even worse.
{quote}and Extra overhead as Ayush Saxena mentioned.
Audit log ( for debugging) and RPC call
{quote}
I think we have a common understanding with [~ayushtkn] here that the overhead
would be worth it. [~ayushtkn] can you please comment?
{quote}If we really required why can't we do through getserverdefaults()(by
adding EC field there).
{quote}
I think any change on the default EC policy would not be reflected in the
serverdefaults on the client without config re-distribution that might also
lead to confusions.
> ECAdmin NPE with -setPolicy -replicate
> --------------------------------------
>
> Key: HDFS-13998
> URL: https://issues.apache.org/jira/browse/HDFS-13998
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.2.0, 3.1.2
> Reporter: Xiao Chen
> Assignee: Zsolt Venczel
> Priority: Major
> Attachments: HDFS-13998.01.patch, HDFS-13998.02.patch,
> HDFS-13998.03.patch
>
>
> HDFS-13732 tried to improve the output of the console tool. But we missed the
> fact that for replication, {{getErasureCodingPolicy}} would return null.
> This jira is to fix it in ECAdmin, and add a unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
