[ 
https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700824#comment-16700824
 ] 

Ayush Saxena commented on HDFS-13998:
-------------------------------------

Thanx [~zvenczel] & [~templedf] for initiating the discussion.
{quote}Let's set the policy but not say to what!
{quote}
Definitely this could be a possibility in case when we intend to set the 
default policy,and user might not be aware of the default policy and even 
intends to know what it is.Rather than just being sure that the file that he is 
gonna write will be erasure coded in a default EC policy set by the ADMIN.

I guess the existing setPolicy fairs well in case of other cases as in when we 
have specified the name.Then there is no scope for confusion and even in the 
case if the user just wants to go in ADMIN's way.

But the case that we are talking that he sets it but doesn't actually gets to 
know what it set and probably wanted to know also ,for genuine reasons.

I guess we can handle this case with this existing setPolicy in a way that if 
we introduce an optional flag as in -getPolicy or -getDefault(Anything like 
that) and the user can set use this flag along with the command if he wants to 
know.By implementation point we can check this same flag inside the same If 
block we talked above.if this flag is set we can fetch the name and if not go 
on with our existing behavior. This way I guess we can justify I guess almost 
all queries so far received.The addl. RPC one --> Now User has only called for 
it know and even won't effect the existing behavior.Since Our change would come 
only when this optional flag is set else it would behave as previously .

Just an Opinion!!! :)

> ECAdmin NPE with -setPolicy -replicate
> --------------------------------------
>
>                 Key: HDFS-13998
>                 URL: https://issues.apache.org/jira/browse/HDFS-13998
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: erasure-coding
>    Affects Versions: 3.2.0, 3.1.2
>            Reporter: Xiao Chen
>            Assignee: Zsolt Venczel
>            Priority: Major
>         Attachments: HDFS-13998.01.patch, HDFS-13998.02.patch, 
> HDFS-13998.03.patch
>
>
> HDFS-13732 tried to improve the output of the console tool. But we missed the 
> fact that for replication, {{getErasureCodingPolicy}} would return null.
> This jira is to fix it in ECAdmin, and add a unit test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to