[
https://issues.apache.org/jira/browse/HDDS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684050#comment-16684050
]
Mukul Kumar Singh commented on HDDS-576:
----------------------------------------
Thanks for working on this [~nandakumar131]. The patch looks good to me. Some
minor comments.
I am +1 on the patch generally, pending jenkins.
1) CloseContainerEventHanlder.java:70, please add a comment, that container
needs to be re fetched to get the container info with new state.
2) Should a helper function be added to MiniOzoneCluster to return a pipeline
for a container info ? There are lots of places in code where such a transform
is done, This can also be done as a separate jira
> Move ContainerWithPipeline creation to RPC endpoint
> ---------------------------------------------------
>
> Key: HDDS-576
> URL: https://issues.apache.org/jira/browse/HDDS-576
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Mukul Kumar Singh
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDDS-576.000.patch
>
>
> With independent Pipeline and Container Managers in SCM, the creation of
> ContainerWithPipeline can be moved to RPC endpoint. This will ensure clear
> separation of the pipeline Manager and Container Manager
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
