[ 
https://issues.apache.org/jira/browse/HDDS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684172#comment-16684172
 ] 

Nanda kumar commented on HDDS-576:
----------------------------------

[~msingh], thanks for the review.
{quote}CloseContainerEventHanlder.java:70, please add a comment, that container 
needs to be re fetched to get the container info with new state.
{quote}
Will do this while committing.
{quote}Should a helper function be added to MiniOzoneCluster to return a 
pipeline for a container info ? There are lots of places in code where such a 
transform is done, This can also be done as a separate jira
{quote}
There is a plan to introduce a getPipeline API given a container Id in SCM 
client protocol itself. After that improvement we don't need any helper method. 
After that, we can also remove getContainerWithPipeline call.

I will take care of the checkstyle issue while committing.

Created HDDS-831 for TestOzoneShell failure.

> Move ContainerWithPipeline creation to RPC endpoint
> ---------------------------------------------------
>
>                 Key: HDDS-576
>                 URL: https://issues.apache.org/jira/browse/HDDS-576
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>            Reporter: Mukul Kumar Singh
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDDS-576.000.patch
>
>
> With independent Pipeline and Container Managers in SCM, the creation of 
> ContainerWithPipeline can be moved to RPC endpoint. This will ensure clear 
> separation of the pipeline Manager and Container Manager



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to