[
https://issues.apache.org/jira/browse/HDDS-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691118#comment-16691118
]
Ajay Kumar commented on HDDS-795:
---------------------------------
[~elek] thanks for posting the patch. Could you please rebase the patch. v4
looks good, few NITs.
* DBStore
** L109: Rephrase "A init a holder" to "Initialize atomic batch operations." or
something similar?
** L114 missing throws clause?
** L120: typo "de"
* BatchOperation: Should this have api for commit op as well?
* Table
** L51: Rename new put operation to "addToBatch"
* Unused imports in VolumeManagerImpl.
* TestRDBTableStore
** L169: Shall we assert key doesn't exist before commit op?
{{Assert.asserNull(testTable.get(key));}}
** L190: Similarly assert if key exist before we commit the batch.
> RocksDb specific classes leak from DBStore/Table interfaces
> -----------------------------------------------------------
>
> Key: HDDS-795
> URL: https://issues.apache.org/jira/browse/HDDS-795
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDDS-795.001.patch, HDDS-795.002.patch,
> HDDS-795.003.patch, HDDS-795.004.patch
>
>
> org.apache.hadoop.utils.db.RocksDB and Table interfaces provide a
> vendor-independent way to access any key value store.
> The default implementation uses RocksDb but other implementation also could
> be used (for example an InMemory implementation for testing only).
> The current Table interface contains methods which depend on RocksDB specific
> classes. For example:
> {code}
> public interface DBStore extends AutoCloseable {
> //...
> /**
> * Return the Column Family handle. TODO: This leaks an RockDB abstraction
> * into Ozone code, cleanup later.
> *
> * @return ColumnFamilyHandle
> */
> ColumnFamilyHandle getHandle();
> //...
> {code}
> We need to remove the RocksDB specific classes from the generic interfaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
