[ 
https://issues.apache.org/jira/browse/HDDS-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695250#comment-16695250
 ] 

Hudson commented on HDDS-795:
-----------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15490 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15490/])
HDDS-795. RocksDb specific classes leak from DBStore/Table interfaces. (ajay: 
rev 8d2789c5ebca007a079caee9c6607ec6c2cddf47)
* (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/Table.java
* (edit) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java
* (edit) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStore.java
* (add) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/BatchOperation.java
* (edit) 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManagerImpl.java
* (edit) 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyDeletingService.java
* (edit) 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
* (add) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBBatchOperation.java
* (edit) 
hadoop-hdds/common/src/test/java/org/apache/hadoop/utils/db/TestRDBTableStore.java
* (edit) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java


> RocksDb specific classes leak from DBStore/Table interfaces
> -----------------------------------------------------------
>
>                 Key: HDDS-795
>                 URL: https://issues.apache.org/jira/browse/HDDS-795
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDDS-795.001.patch, HDDS-795.002.patch, 
> HDDS-795.003.patch, HDDS-795.004.patch, HDDS-795.005.patch, 
> HDDS-795.006.patch, HDDS-795.007.patch
>
>
> org.apache.hadoop.utils.db.RocksDB and Table interfaces provide a 
> vendor-independent way to access any key value store. 
> The default implementation uses RocksDb but other implementation also could 
> be used (for example an InMemory implementation for testing only).
> The current Table interface contains methods which depend on RocksDB specific 
> classes. For example:
> {code}
> public interface DBStore extends AutoCloseable {
> //...
> /**
>    * Return the Column Family handle. TODO: This leaks an RockDB abstraction
>    * into Ozone code, cleanup later.
>    *
>    * @return ColumnFamilyHandle
>    */
>   ColumnFamilyHandle getHandle();
> //...
> {code}
> We need to remove the RocksDB specific classes from the generic interfaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to