[
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710384#comment-16710384
]
Allen Wittenauer commented on HDDS-891:
---------------------------------------
-1
I'm going to stop you from shooting yourself in the foot here.
bq. But in Ozone:
That list may be true for patches that only modify hadoop-ozone or hadoop-hdds
maven modules, but patches uploaded to the HDDS project sometimes hit more than
just those modules (e.g., the last two changes to /pom.xml came from HDDS!).
Plus the union between those two modules is the root of the tree which means it
really is building everything.
It's important to also remember that hadoop-ozone and hadoop-hdds are fair game
to be modified in by other JIRA projects as well.
Consider some other things:
a) Re-arrange the source such that there aren't two children off of / such that
modifying both modules won't trigger a full build.
b) Modify the existing personality to slap -Phdds when the changed files list
includes hadoop-ozone and hadoop-hdds.
c) It should probably also trigger a native library build. (There's a
tremendous amount of inconsistency with the test runs presently.)
d) Modify the personality to skip shaded if the patch ONLY modifies
hadoop-ozone/hadoop-hdds
With the exception of the first, these are all pretty trivial to do and have a
way higher chance of success.
> Create customized yetus personality for ozone
> ---------------------------------------------
>
> Key: HDDS-891
> URL: https://issues.apache.org/jira/browse/HDDS-891
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
>
> Ozone pre commit builds (such as
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for
> specific builds.
> The hadoop personality tries to identify which project should be built and
> use partial build to build only the required subprojects because the full
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always
> should be executed as it contains many generic unit test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
